microsoftgraph
[QUESTION] Should we re-home the samples in this repo?
At present we have a number of sample applications and usages hosted within this repository.
One of them is responsible for a large number of the Dependabot noise that we can see in the Pull Requests section.
Separating these samples into a separate repo would reduce the noise in here and focus the work, OTOH, having the samples elsewhere could easily create a situation where the issues are simply hidden away out of site. One other related thought is that potentially these sample applications could be used as consumers of the library in order to test pre-release builds as changes are made to the library as an additional means to detect breaking changes.
Hello gavinbarron, thank you for opening an issue with us!
I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌
I'm thinking the same. Having them outside of the main repo seems like a good first step. Having users building the entire repo to get to their sample seems counter-intuitive... So I'm an advocate of sharing these samples elsewhere (either community-based repos like PnP or another samples specific repo in the Graph organization). @aycabas is working on new samples for React, HTML, etc that could fit in this discussion also...
I agree the samples could be looked at as test cases for the framework. The sample shouldn't contain a lot of extraneous code. It seems like this is more of a deployment setup issue. Would using the directory configuration option solve the problem?
Sure, using the directory configuration would hide the problem of having dependency issues in our samples. But IMO they should be kept up to date to, just not with as much criticality as for the core code.
I would agree they should be kept up to date, but I don’t agree with the “term hide the problem”. Following that philosophy, moving the project to another repository would also be bidding the problem.
I would be in favor of failing the build if dependencies are out of date.
Most samples are going to be re-homed in the pnp/mgt-samples repository. We'll keep the react-contoso sample here for testing purposes alongside Storybook and the developer page