vscode-remote-release icon indicating copy to clipboard operation
vscode-remote-release copied to clipboard

[Remote-SSH Bug]: v0.108.0 can't handle empty ssh config

Open JamyDev opened this issue 1 year ago • 3 comments

Is there an existing issue for this bug?

  • [X] I have searched the existing issues

Required Troubleshooting Steps

  • [X] I have followed these troubleshooting steps
  • [X] I have tried both values of the remote.SSH.useLocalServer setting

Connect Locally

It connects successfully

->

No response

Expected Behavior

No response

Steps To Reproduce

No user configuration, on 0.108.0 (as well as the latest pre-release) I get the following error when connecting:

TypeError: Cannot read properties of undefined (reading 'after')
	at w (/Users/jamy/.vscode/extensions/ms-vscode-remote.remote-ssh-0.108.0/out/extension.js:2:415403)
	at $ (/Users/jamy/.vscode/extensions/ms-vscode-remote.remote-ssh-0.108.0/out/extension.js:2:564499)
	at async A (/Users/jamy/.vscode/extensions/ms-vscode-remote.remote-ssh-0.108.0/out/extension.js:2:564055)
	at async s.parseWithConfig (/Users/jamy/.vscode/extensions/ms-vscode-remote.remote-ssh-0.108.0/out/extension.js:2:583575)
	at async _.resolve (/Users/jamy/.vscode/extensions/ms-vscode-remote.remote-ssh-0.108.0/out/extension.js:2:807104)
	at async g.$resolveAuthority (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:156:18129)

On 0.107.1 it connects just fine. Based on some devtools tracing, it happens during the $resolveAuthority call.

Remote-SSH Log

Remote-SSH Log

[18:24:24.831] Log Level: 2
[18:24:24.835] VS Code version: 1.86.2
[18:24:24.835] Remote-SSH version: [email protected]
[18:24:24.835] darwin arm64
[18:24:27.506] SSH Resolver called for "ssh-remote+jamy.devpod-us-or", attempt 1
[18:24:27.507] "remote.SSH.useLocalServer": true
[18:24:27.507] "remote.SSH.useExecServer": false
[18:24:27.507] "remote.SSH.path": undefined
[18:24:27.507] "remote.SSH.configFile": undefined
[18:24:27.507] "remote.SSH.useFlock": true
[18:24:27.507] "remote.SSH.lockfilesInTmp": false
[18:24:27.507] "remote.SSH.localServerDownload": auto
[18:24:27.507] "remote.SSH.remoteServerListenOnSocket": false
[18:24:27.507] "remote.SSH.showLoginTerminal": false
[18:24:27.510] "remote.SSH.defaultExtensions": []
[18:24:27.510] "remote.SSH.loglevel": 2
[18:24:27.510] "remote.SSH.enableDynamicForwarding": true
[18:24:27.510] "remote.SSH.enableRemoteCommand": false
[18:24:27.510] "remote.SSH.serverPickPortsFromRange": {}
[18:24:27.510] "remote.SSH.serverInstallPath": {}

Anything else?

No response

JamyDev avatar Feb 23 '24 02:02 JamyDev

Found the culprit: My ~/.ssh/config file was blank. Probably oughta handle that case:

❯ cat ~/.ssh/config

JamyDev avatar Feb 23 '24 02:02 JamyDev

I have exactly the same issue.

FrsECM avatar May 03 '24 16:05 FrsECM

Sorry for the slow response- I can't repro it in the latest, does it still happen for you?

roblourens avatar May 18 '24 00:05 roblourens

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

vscodenpa avatar May 25 '24 12:05 vscodenpa