vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Dropdown buttons have two different visuals

Open bpasero opened this issue 8 months ago • 5 comments

GitHub PR (webview):

Image

In our workbench otherwise:

Image Image

I think we should land on one to be consistent.

//cc @alexr00

bpasero avatar Mar 17 '25 10:03 bpasero

Gut reaction is to align with workbench view

mrleemurray avatar Mar 17 '25 10:03 mrleemurray

I agree, we should align with workbench.

alexr00 avatar Mar 17 '25 11:03 alexr00

Yep +1 to workbench style.

hawkticehurst avatar Mar 17 '25 13:03 hawkticehurst

@alexr00 @bpasero what action is needed from the design team?

kkbrooks avatar May 07 '25 17:05 kkbrooks

I don't think any action is needed from the design team, unless you really want to go change the css and html yourself :). I know GHPR should match the style in VS Code, I just need to go in and do it!

alexr00 avatar May 08 '25 08:05 alexr00

Ended up doing this as part of the header redesign.

alexr00 avatar Jul 23 '25 12:07 alexr00