vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Search string in modified pull request files

Open Splines opened this issue 1 year ago • 2 comments

Thanks for this amazing extension, works like a charm 🎉

A feature I'd be looking forward to is to limit the VSCode in-built search to files that were modified in the currently checked out pull request. Additionally, an option to only search in the modified lines of these files would also be great.

This feature could help get a better understanding of what a PR changed as you would be able to easily search in it for strings you've seen somewhere in the modified lines and find out about its usage and how files are related to each other. Without this limited search, many more occurrences of a given string in the entire codebase might show up making it harder to discern what was changed in the PR and what not.

Splines avatar Sep 23 '24 08:09 Splines

Cool idea! @andreamah is this something that the search API you've been working on might enable?

alexr00 avatar Sep 26 '24 10:09 alexr00

Hmm. Since the files will still be of file scheme, the fileSearchProvider and textSearchProvider won't apply to this case. It's mostly if you have a custom filesystem / scheme.

andreamah avatar Sep 26 '24 16:09 andreamah

Duplicate of #5752

alexr00 avatar Dec 16 '24 11:12 alexr00

Hi @Splines , @alexr00 , @andreamah is this merged in? If so how do I use it?

Tushar1729-k avatar Apr 14 '25 19:04 Tushar1729-k

@Tushar1729-k "Duplicate" does not mean that a feature request was implemented, instead just that there was already another issue that requested the same feature, see #5752, which is open.

Splines avatar Apr 14 '25 20:04 Splines