'Not all changes could be converted to suggestions'

[joshspicer]

Testing #6160

I may be understanding what "commenting range" here is, but I presumed that this change in the attached video should be ok?

https://github.com/user-attachments/assets/c4e1bef5-0c17-4e3c-8df1-c28f3e4cc692

[alexr00]

I don't any commenting ranges in the diff editor that you have open. Is that file part of the PR that y9ou currently have checked out?

[joshspicer]

Yes, it's part of a PR. In this example i've included the bottom status bar that shows this change is part of https://github.com/joshspicer/almost-empty/pull/6

I think i'm not understanding what constitutes a 'commenting range'? For example on line 4 here I made an edit (and commented on it), then ran the action from the SCM panel.

[alexr00]

A commenting range is wherever you see the commenting bar and can leave a comment. If you make a change that's within that range then it should work, with the caveat that if you add or remove a line at the edge of a range it might not work because of where GitHub defines the ranges.

It looks like you made the change within a commenting range. Can you share a link to the PR by chance?

[joshspicer]

Here's the PR: https://github.com/joshspicer/almost-empty/pull/6

[alexr00]

The issue is when the only changes are line insertions.

[joshspicer]

I am no longer seeing the option available:

[alexr00]

Verified with @joshspicer in a call.