vscode-pull-request-github
vscode-pull-request-github copied to clipboard
Adding a comment is always associated with a review
- Extension version: v0.92.0
- VSCode Version: 1.91.0
- OS: macOS Sonoma 14.5
Whenever I add a comment through the extension, it shows up as a review comment, see e.g. https://github.com/mne-tools/mne-python/pull/12707#pullrequestreview-2171610586. However, that's not what I want to do, and I think that's also not what is supposed to happen. What should happen instead is that a normal comment is added to the discussion.
Steps to Reproduce:
- Check out some PR
- Add a new comment
- The comment is associated with a review, which should not happen in my opinion
I see what you're saying. We don't currently have a way to leave a PR review comment vs. a discussion comment.
Oh, thanks for clarifying, I didn't know that! It would be great to have of course!
Especially if you are trying to use this plugin with a GitOps automation system. As they typically only watch PRs for discussion/issue comments not review comments.
@alexr00 This was possible recently, there was a button with Add Comment label, now is not possible anymore, what happened ?
Before
Now
Seems it comes from installing the latest update of the extension
The "Add comment" button is still there. Once you have a review in progress, we only show the "add review comment" button. Once you submit your review, or before you start a review, you have the choice between adding a comment a starting a review.
@alexr00 You are right thanks