vscode-pull-request-github
vscode-pull-request-github copied to clipboard
Extension causes closed "new text file" editors to be reopened
- Extension version:v 0.92.0
- VSCode Version: latest
- OS: macOs
Steps to Reproduce:
- Open any text file in a workspace.
- Command+N to open a new text editor (not associated with an actual file)
- Type some random text in the editor, but without saving it anywhere:
- Close the file (pick "don't save" for the modal that appear), this brings the first editor back into view
- wait a second or two, and the "new text editor" is reopened (behind the active editor). The editor comes back as "dirty", although it is now empty:
When disabling this extension, the problem can't be reproduced.
I can't reproduce this. Does it always happen for you?
Yes, I can reproduce this easily in several workspaces. I ran extension bisect and it identified this extension (which I had already determined manually).
If I try to reproduce in a workspace where git has been initialized, but not pushed to a remote server, I am unable to reproduce. I can only reproduce when working in a branch that exists on the origin.
Are you on a PR branch, the repo default branch, or some other branch that exists on the origin?
It happens:
- in the
masterbranch - in branches that have been pushed (regardless of whether a PR exists)
- in branches that only exist locally
@dinofx I still can't repro this. I strongly suspect it's being caused by a different extension. Are you still seeing it?
I have this extension installed: alefragnani.separators
If I disable this extensions (but keep all my others enabled), the problem goes away. However if I enable ONLY this extension and yours, I can't reproduce the problem. It seems to be a combination of 3 or more extensions. If I nail down the combination I'll let you know.