vscode-pull-request-github
vscode-pull-request-github copied to clipboard
microsoft
Emoji aren't rendered in code review
Type: Bug
- Have a clone of https://github.com/CrunchyData/postgres-operator/
- Open it in VS Code
- Open the Pull Requests extensions view
- Expand the https://github.com/CrunchyData/postgres-operator/pull/3856 PR
- Scroll to and select internal/controller/postgrescluster/pgbackrest_test.go
- Scroll to the comment on line 732
- Click on the comment indicator (note that this won't work anymore as the comment has been resolved, but it worked at the time -- and I have a screenshot)
- See the comment with
:wrench:instead of :wrench:
Extension version: 0.80.1 VS Code version: Code 1.86.2 (Universal) (903b1e9d8990623e3d7da1df3d33db3e42d80eda, 2024-02-13T19:42:13.651Z) OS version: Darwin arm64 23.2.0 Modes:
System Info
| Item | Value |
|---|---|
| CPUs | Apple M1 Max (10 x 24) |
| GPU Status | 2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled webgpu: enabled |
| Load (avg) | 6, 6, 6 |
| Memory (System) | 64.00GB (0.04GB free) |
| Process Argv | --crash-reporter-id 1fc67ee2-0174-4598-9f98-4537df0dd32c |
| Screen Reader | no |
| VM | 0% |
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
vscrp:30673768
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
d6fi2104:30959263
fegfb526:30961430
7j2b6412:30967274
e3gdj431:30958358
ccp2r3:30958157
@mjbvz it would be cool if our markdown renderer supported this.
Note for later if I want to add support in the extension: https://emojipedia.org/shortcodes
This extension adds support for the markdown preview: https://marketplace.visualstudio.com/items?itemName=bierner.markdown-emoji
However this rendering comes from core, so we're unlikely to add support there. What you could potentially do is do a prepass to replace the :emoji: in the markdown you pass to core
@mjbvz there's a stray , in the description:
Adds :emoji: syntax support to VS Code's built-in Markdown preview and to ,markdown cells in notebooks.