vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

PR comments added using the VSCode plugin are not triggering the issue_comment.created WebHook

Open john-gomersall opened this issue 1 year ago • 3 comments

When I comment on a PR in VS Code it does not seem to trigger our Webhook which is configured to with "Issue comments". Logging the same comment via the GitHub web UI does trigger the Webhook.

  • Extension version: 0.78.0
  • VSCode Version: 1.85.0
  • OS: Linux x64 5.15.133.1-microsoft-standard-WSL2
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repository
  • Github Product (Github.com/Github Enterprise version x.x.x): Github.com

Steps to Reproduce:

  1. Configure a WebHook to trigger on Issue Comments
  2. Create a PR and view in VSCode
  3. Add a PR comment in VSCode
  4. Webhook is not fired

john-gomersall avatar Dec 15 '23 12:12 john-gomersall

Interesting. Are you adding a single comment or adding a review comment? I am not familiar with webhooks, but I would expect an "Issue Comment" would actually be neither of these things. Does the webhook fire when you add a PR comment on github.com?

alexr00 avatar Jan 19 '24 10:01 alexr00

Interesting. Are you adding a single comment or adding a review comment? I am not familiar with webhooks, but I would expect an "Issue Comment" would actually be neither of these things. Does the webhook fire when you add a PR comment on github.com?

Just adding a single comment to the PR. The web hook fires fine when the comment is added on github.com, but doesn't fire when entered in VSCode. The comments look identical when viewed in github.

john-gomersall avatar Jan 19 '24 10:01 john-gomersall

Observing the same with v0.82.1 today.

sandro-meier avatar Mar 25 '24 10:03 sandro-meier