vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Continues to process queued requests after rate limit has been hit

Open meganrogge opened this issue 2 years ago • 1 comments

Testing #4646

I pressed refresh a bunch of times and eventually saw the notification. I expected it to stop processing for a while and to not show any more notifications. Instead, it continued to process the queued requests and showed the notifications several more times.

https://user-images.githubusercontent.com/29464607/226647943-98fd58e8-28ce-4b6a-9b90-5805b63bbdca.mov

meganrogge avatar Mar 21 '23 15:03 meganrogge

I supposed if the rate limit is hit multiple times then we could shut things down. I'm hesitant to do that though as this rate limit has not been in the stable release yet. I'll check back in after a release or two and see if we're hitting this rate limit infrequently enough that it's safe to shutdown if this happens.

alexr00 avatar Apr 19 '23 14:04 alexr00