vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Follow open files in the PR changes view

Open alexr00 opened this issue 2 years ago • 6 comments

Requested by @digitarald:

When a file that's in the currently checked out PR is opened (even when it's not a diff) we should highlight the file in the "Changes" view if it's open.

alexr00 avatar Feb 13 '23 16:02 alexr00

This would be helpful for maintaining context when jumping between files via "go to definition".

diminutivesloop avatar Sep 22 '23 18:09 diminutivesloop

We already do this.

alexr00 avatar Dec 15 '23 10:12 alexr00

@alexr00 Are you sure this already works? I'm on the pre-release version (v0.79.2023121409) and files are still only highlighted in the changes view if I open them by directly clicking in that view.

diminutivesloop avatar Dec 15 '23 13:12 diminutivesloop

Here's what I see:

Recording 2023-12-15 at 18 00 01

Can you share a gif of what you're seeing?

alexr00 avatar Dec 15 '23 17:12 alexr00

Ok looks like it works when I re-enable explorer.autoReveal. I believe I disabled that setting because I didn't like the explorer jumping around when I switched files, but I'll try out re-enabling it and see if it's still a problem. I wonder if it would make sense to have a separate version of that setting for this extension.

diminutivesloop avatar Dec 18 '23 14:12 diminutivesloop

So I've tried re-enabling explorer.autoReveal and it's honestly pretty annoying. Would love to have a separate option for this extension.

diminutivesloop avatar Jan 17 '24 14:01 diminutivesloop