vscode-pull-request-github Show diffs for text files only

Show diffs for text files only

Open kieferrm opened this issue 4 years ago • 1 comments

In focus mode we automatically show the first diff. We should only do this for text files, otherwise I get:

Feb 04 '21 20:02 kieferrm

Changes are needed in this method to make sure the file we're opening makes sense:

https://github.com/microsoft/vscode-pull-request-github/blob/a3040499b41ea55fcab3500bf599b7f0c5e7a98e/src/view/reviewManager.ts#L409-L421

Mar 02 '22 15:03 alexr00

Now, we will try to find a non-media file to show. If there are none then we could still end up showing a non-text file.

Dec 12 '22 12:12 alexr00