Jupyter notebook diff experience

[ankitbko]

VSCode insider has updated Jupyter notebook experience with ability to show diff in more readable format (rather than diff of json). This experience does not work with PR yet. Any plans of integrating with that? https://code.visualstudio.com/updates/v1_49#_notebooks

[RMacfarlane]

This would be cool!

cc @rebornix do you have a sense of how difficult this would be?

[rebornix]

@RMacfarlane As long as the notebook content provider uses the workspace fs api to resolve file content, it will work out of the box. We can meet and evaluate GitHub Issue Notebook together first and then suggest changes to the Jupyter notebook.

[jucor]

This would be awesome. I can't get it to work: I get an error "No file system provider found for resource":

I can open the Modified file, but when I try to open the Original file I get a similar error:

[Edit] I found out why: my main branch wasn't up-to-date: the commit in main branch where that ipynb was introduced hadn't been pulled yet. Therefore the extension was struggling to find it, which might explain the error. Could be handy to have a clearer error message :)|

Now that I have correctly pulled main, however, the behaviour is still weird:

• If I right-click and pick "Open original file", I get a nice notebook view in VSCode.
• If I right-click and pick "Open modified fiel", I get the JSON view in VSCode :( not the nice notebook view that I was expecting.
• and the kicker: double-clicking on the ipynb file in the Pull Request list throws the error below, instead of the nice VSCode notebook diff I was expecting:

Any idea how to get it to work "out of the box" please? I'm on VSCode 1.60.0 on Windows 10, working over SSH remote to a linux box.

[anaclaramatos]

@rebornix any updates on this? being able to code review notebooks with proper rendering from within vscode would be amazing

[IceTDrinker]

What would it take to get the notebook diff view?

Apparently diffs/changes for ipynb files are generated as RemoteFileChangeNode which triggers the notification and the "open in browser" thing but it's not clear to me why it's not generated as a GitFileChangeNode.

I'm definitely not a TypeScript dev (and certainly not a vscode dev either) so it would probably be hard to contribute but that functionnality would be extremely useful (one better on GitHub even!) so I'm willing to contribute whatever help I can!

Cheers

[janosh]

Is there an equivalent issue somewhere about adding this to GitHub's web interface?

[lgonzalezsa]

This will be awesome, if I can suggest as well to include the navigation minimap to identify where the code was changed.

[alexr00]

This has been fixed in the mean time.