vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Allow to see commits of a PR without checking out to it

Open Yuuki77 opened this issue 5 years ago • 9 comments

Fixes https://github.com/microsoft/vscode-pull-request-github/issues/2201 now you can see the commits without checking out

So I decided to use files folder and commit folder. image

Yuuki77 avatar Oct 30 '20 12:10 Yuuki77

CLA assistant check
All CLA requirements met.

ghost avatar Oct 30 '20 12:10 ghost

@RMacfarlane Thank you for the feedbacks! I see! Can you tell me how to reproduce that kind of issue? When I tested, I could see the commits in Allfolder I thought I did not have commits for these prs

Yuuki77 avatar Nov 12 '20 01:11 Yuuki77

Sure! Here is a way to reproduce the issue:

  1. Open a pull request using the extension
  2. Open the PR on GitHub.com and then go to the branch it is from. You can click on a file and use the edit button to make a commit on GitHub.com
  3. Back in VS Code, refresh the pull request tree
  4. Open the new commit node and click on a file

It should show two error notifications saying "We couldn't find commit <commitId>"

RMacfarlane avatar Nov 13 '20 17:11 RMacfarlane

@RMacfarlane Thank you for the instructions. Hmm I could not reproduce the issue. I followed the instructions and when I clicked the refresh, I can see the new commits. 🤔

Yuuki77 avatar Nov 15 '20 14:11 Yuuki77

Hmm, do you by chance have the git.autofetch setting set to true?

RMacfarlane avatar Nov 16 '20 23:11 RMacfarlane

@RMacfarlane you are right.git.autofetch is true in my settings. let me test again when I set this to false! 💪

Yuuki77 avatar Nov 17 '20 01:11 Yuuki77

@RMacfarlane still investigating.. Which function should I call to fetch the commit locally? This is what I did so far but still not working 😓 https://github.com/microsoft/vscode-pull-request-github/pull/2245/commits/6a366acd200dff9d3d1425a1ba4f4c205af7bbb9

Yuuki77 avatar Nov 30 '20 12:11 Yuuki77

i dont bro im new at this

toriibby avatar Feb 16 '21 13:02 toriibby

test

Saleciani avatar Jul 05 '22 16:07 Saleciani

@Yuuki77 thank you for the PR. As part of our annual GitHub PR and issue clean up, I'm going to close this PR since there hasn't been any activity on it in 2 years. If you still plan to work on it please let me know and I'll re-open it!

alexr00 avatar Dec 19 '22 14:12 alexr00