vscode-docs icon indicating copy to clipboard operation
vscode-docs copied to clipboard

New Docker extension setting name

Open bwateratmsft opened this issue 3 years ago • 2 comments

With https://github.com/microsoft/vscode-docker/issues/3539 we have changed the name of a setting in the Docker extension.

Note: Please hold off on merging this until we release Docker extension version 1.23.0, tentatively in September.

/cc @ucheNkadiCode

bwateratmsft avatar Jul 20 '22 16:07 bwateratmsft

/cc @chrmarti too since I updated the Remote - Containers doc

bwateratmsft avatar Jul 20 '22 16:07 bwateratmsft

I made an update since we changed the setting name back to docker.environment.

bwateratmsft avatar Aug 31 '22 13:08 bwateratmsft

@bwateratmsft Is there an ETA for the v1.23 update? I see we're still on v1.22 as of 10/13.

ghogen avatar Oct 13 '22 17:10 ghogen

@ghogen We don't have an ETA yet but it's getting sooner. The big thing we're waiting on is changing to use the CLI only, that has finally made it to full-blown PR this week after months of being stuck on one thing or another.

bwateratmsft avatar Oct 13 '22 17:10 bwateratmsft

@ghogen @gregvanl This can now be merged.

/cc @chrmarti for the update to the Remote Containers doc.

bwateratmsft avatar Nov 28 '22 19:11 bwateratmsft

@bwateratmsft There are also references to docker.host and docker.context in the https://code.visualstudio.com/remote/advancedcontainers/develop-remote-host. For example in https://code.visualstudio.com/remote/advancedcontainers/develop-remote-host#_a-basic-remote-example. I'll merge and publish this PR but could you also update that topic in a follow-up PR? Thanks

gregvanl avatar Nov 28 '22 21:11 gregvanl

Will do, thanks @gregvanl!

bwateratmsft avatar Nov 28 '22 21:11 bwateratmsft

@bwateratmsft I think these should be all cases where we have this in documentation for Remote-Containers (renamed to Dev Containers). Let me know when there are any I miss. Thanks!

chrmarti avatar Dec 02 '22 08:12 chrmarti