Go 1.18 release broke fallback logic for go script

[Chuxel]

The go script does not properly handle a scenario where a version number for a Go release does not include a breakfix version number - e.g. the release here is 1.18, not 1.18.0.

As a workaround, set the version number to 1.17.8 for now.

[Chuxel]

Fixed in https://github.com/microsoft/vscode-dev-containers/commit/c694b3cfe0551cc4da2315ba9ffbd8aa78d1db6e

Leaving open until release.

[jbreiding]

I am using a copy of the script from main at the moment.

As of today there is a tag for 1.18.1 on the git repo, but no corresponding release.

The script is terminating with the 404 because the release binary does not exist.

I imagine there might be some latency between tagging the repo and release artifacts making it to the official downloads.

#12 43.04 TARGET_GO_VERSION=1.18.1
#12 43.27 GO_GPG_KEY_URI=https://dl.google.com/linux/linux_signing_key.pub
#12 43.39 Downloading Go 1.18.1...
#12 43.82 curl: (22) The requested URL returned error: 404 
#12 43.84 (!) Download failed.
#12 ERROR: executor failed running 

[Chuxel]

For some reason ((breakfix=breakfix-1)) is causing the script to exit with set -e in the fallback logic. No idea why. Will work on a fix.

[jbreiding]

For some reason ((breakfix=breakfix-1)) is causing the script to exit with set -e in the fallback logic. No idea why. Will work on a fix.

I was about to start tinkering locally with this, happy to offer any help.

[jbreiding]

So maybe I am too quick here, your PR did work for me locally.

Thanks for being so responsive.

[Chuxel]

@jbreiding Perfect! Was just about to ask. Will merge.

[Chuxel]

PR has been merged, so if you are using a copy of the script, you can grab the latest from "main". https://github.com/microsoft/vscode-dev-containers/blob/main/script-library/go-debian.sh

For use in features, you can reference this repository's copy of the feature for the moment to get the latest copy of it.

"features": {
    "microsoft/vscode-dev-containers/[email protected]": "latest"
}

It will update in Remote - Containers and Codespaces before long as well.

[Chuxel]

Resolved a while ago.