vscode-cpptools icon indicating copy to clipboard operation
vscode-cpptools copied to clipboard

Inlay Hint settings not available in workspace folder settings.json

Open H-G-Hristov opened this issue 3 years ago • 4 comments

Feature Request

Why is that so? What about a single setting to enable all of them by default too?

Screenshot 2022-08-24 at 10 20 07

H-G-Hristov avatar Aug 24 '22 07:08 H-G-Hristov

@Colengms Assigning this to you since you're making changes to settings.

michelleangela avatar Aug 25 '22 17:08 michelleangela

This is "by design". I don't think we want to enable the inlay settings to be changed per-workspace folder unless we have a reason to.

The multiple settings follows the approach taken by TypeScript, i.e. they do not have "a single setting to enable all of them by default".

sean-mcmanus avatar Aug 25 '22 18:08 sean-mcmanus

TypeScript's inlayHint settings are all resource scope: vscode/package.json at 662ba37e022f6339f372f810ee248dddfd6fcfd6 · microsoft/vscode (github.com)

The editor.inlayHints.enabled setting also appears to be resource scope (though, I can't find where it's declared. When I switch to folder-specific mode in VS Code's settings UI, that setting is still available.)

It seems like our settings should be consistent with those.

Colengms avatar Aug 26 '22 18:08 Colengms

Yeah, but they may have a reason for doing that which isn't applicable to our C/C++ experience? I can't think of a reason why a user would want to inlay hints for only a subset of workspace folders.

sean-mcmanus avatar Aug 26 '22 18:08 sean-mcmanus

Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/v1.13.2

sean-mcmanus avatar Oct 06 '22 14:10 sean-mcmanus