vscode-cpptools icon indicating copy to clipboard operation
vscode-cpptools copied to clipboard

chore: remove Visual Studio-related files for cross-platform cleanup

Open Subham-KRLX opened this issue 5 months ago • 1 comments

This PR removes the build.cmd batch file from the Code Samples/Fib/ folder.

Since this file is specific to Windows and Visual Studio environments, removing it helps streamline the repository for cross-platform development and makes it cleaner for non-Windows contributors.

This is part of a minor cleanup effort to reduce legacy or unused platform-specific files.

Subham-KRLX avatar Jun 15 '25 03:06 Subham-KRLX

Thanks for the review, @sean-mcmanus! I've now removed the reference to build.cmd from tasks.json as you pointed out. Let me know if there's anything else you'd like me to update.

Subham-KRLX avatar Jun 16 '25 12:06 Subham-KRLX

@sean-mcmanus @Colengms: Understood the issues with build.cmd and MinGW. I’ll:

Revert the build.cmd removal (keep Windows support)

Propose a follow-up PR to replace pthreads with C++11 for true cross-platform support

Will that work? Or should we document the Linux/MacOS-only limitation instead?

Subham-KRLX avatar Jun 26 '25 03:06 Subham-KRLX

@sean-mcmanus @Colengms: Understood the issues with build.cmd and MinGW. I’ll:

Revert the build.cmd removal (keep Windows support)

Propose a follow-up PR to replace pthreads with C++11 for true cross-platform support

Will that work? Or should we document the Linux/MacOS-only limitation instead?

Reverting the build.cmd removal and keeping the Windows support (despite that it can't be built successfully on Windows, due to lack of pthreads) would seem to equate to simply abandoning this PR - no changes needed. Making the sample properly cross-platform seems simple enough. Would you like to open an issue to track that?

Colengms avatar Jun 26 '25 19:06 Colengms

Thanks all for the review—looks like the consensus is to keep build.cmd. I’ll close this PR now. I’ll also open a new issue to replace the sample’s pthread calls with standard C++11 for cross-platform compatibility. Reference: #13702.

Subham-KRLX avatar Jun 27 '25 04:06 Subham-KRLX