typescript-go icon indicating copy to clipboard operation
typescript-go copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Block completions in invalid positions

Open gabritto opened this issue 6 months ago • 2 comments

Ports the code that blocks completions in positions such as inside strings when the possible strings aren't constrained by the context. Completions not yet blocked inside comments because isInComment is not ported yet (it lives in the formatter 😬)

gabritto avatar May 21 '25 20:05 gabritto

(it lives in the formatter 😬)

This scared me enough to go look, but it seemingly doesn't actually do anything formatting related; I'm not sure why it lives there in Strada...

jakebailey avatar May 21 '25 20:05 jakebailey

Planning on doing the isInComment in a future PR stuff once I have something basic working for fourslash.

gabritto avatar May 29 '25 21:05 gabritto

Planning on going back and doing the isInComment stuff once I have something basic working for fourslash.

Is this still the case or are you looking for a review now?

andrewbranch avatar Jun 03 '25 21:06 andrewbranch

Planning on going back and doing the isInComment stuff once I have something basic working for fourslash.

Is this still the case or are you looking for a review now?

Sorry, I wasn't clear in my original comment, I meant I'm planning on doing that in a separate PR, so yes, looking for a review.

gabritto avatar Jun 03 '25 22:06 gabritto