torchgeo icon indicating copy to clipboard operation
torchgeo copied to clipboard

IDTReeS: remove support for plotting lidar point cloud

Open adamjstewart opened this issue 1 year ago • 2 comments

I don't think this feature (IDTReeS.plot_las) is widely used and it requires multiple dependencies (pyvista, pyvista/setup-headless-display-action) just to test. Visualization has always been orthogonal to TorchGeo's goals. We would like the bare minimum plotting capable in matplotlib. Users can always use PyVista themselves outside of TorchGeo.

adamjstewart avatar Nov 26 '24 11:11 adamjstewart

I wonder how people would feel about also removing our dependency on laspy, IDTReeS is the only dataset that uses it right now and none of our trainers know what to do with point clouds. Are we planning on adding more lidar datasets in the future?

adamjstewart avatar Nov 26 '24 11:11 adamjstewart

We can also plot the 3D point cloud in matplotlib if this is a useful feature, PyVista is just overkill for our needs.

adamjstewart avatar Nov 26 '24 12:11 adamjstewart

I agree (and would like to remove laspy) -- I'm wondering if we can make this a tutorial or put this snippet somewhere though so people can copy if they want?

calebrob6 avatar Jan 06 '25 21:01 calebrob6

and would like to remove laspy

I'm actually now hesitating about this. I had one audience member at AGU who was particularly interested in lidar support. It's similar to SAR support, where a lot of domain expertise is required to do things correctly and we won't have that until someone contributes it, but I would love to expand our lidar support if we can.

I'm wondering if we can make this a tutorial or put this snippet somewhere though so people can copy if they want?

I would suggest here: https://tutorial.pyvista.org/

adamjstewart avatar Jan 07 '25 09:01 adamjstewart