torchgeo icon indicating copy to clipboard operation
torchgeo copied to clipboard

Deprecate AugmentationSequential wrapper

Open adamjstewart opened this issue 1 year ago • 3 comments

Thoughts on whether we should deprecate this or just remove it? It's been deprecated since 0.4, but also we've been using it continuously since then. We're moving towards a 1.0 release in the future after which we'll need to start formally deprecating things anyway.

adamjstewart avatar Nov 07 '24 09:11 adamjstewart

It looks like NASA Marine Debris and VHR-10 data modules still use the deprecated wrapper?

adamjstewart avatar Nov 07 '24 10:11 adamjstewart

Thoughts on whether we should deprecate this or just remove it? It's been deprecated since 0.4, but also we've been using it continuously since then. We're moving towards a 1.0 release in the future after which we'll need to start formally deprecating things anyway.

I prefer just removing it tbh. But I would like to verify kornia's augmentations work as expected for the detection datasets before that.

It looks like NASA Marine Debris and VHR-10 data modules still use the deprecated wrapper?

Yeah, I was planning to have the object detection datasets switch to Kornia's AugmentationSequential in #1978

ashnair1 avatar Nov 07 '24 10:11 ashnair1

Gotcha, will mark this as a draft and wait on #1978

adamjstewart avatar Nov 07 '24 11:11 adamjstewart

Let's just deprecate it for now. It's only a couple lines of code, it isn't hurting anyone. I think everyone has been using our wrapper up until now, we don't want all of their code to break.

adamjstewart avatar Feb 12 '25 13:02 adamjstewart