tolerant-php-parser icon indicating copy to clipboard operation
tolerant-php-parser copied to clipboard

Enable more concrete rulesets on DelimitedList

Open mousetraps opened this issue 8 years ago • 1 comments
trafficstars

Some delimited lists can have empty elements, and some delimited lists cannot. However, we don't specify concrete rulesets for each of these list types, and everything gets parsed in the most lenient way possible. This produces a valid tree, but also means that we're not providing errors where we should. We should revisit all of the classes that extend DelimitedList and define concrete rulesets for each.

mousetraps avatar Jan 17 '17 20:01 mousetraps

Note: in terms of parsing this is probably a good thing. A post-pass can check for lists that don't have the right number of elements and add errors for them.

CyrusNajmabadi avatar Feb 04 '17 06:02 CyrusNajmabadi