terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Add action for opening settings directory in file explorer

Open e82eric opened this issue 1 year ago • 2 comments

Most of the logic is taken from the original PR (https://github.com/microsoft/terminal/pull/15417) and adapted to work with the palette.

I added 2 additional actions, send settings file path as input and copy settings file path to clipboard. (Totally understand if these should be removed)

open_settings_in_explorer

Summary of the Pull Request

References and Relevant Issues

#12382

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

  • [ ] Closes #xxx
  • [ ] Tests added/passed
  • [ ] Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • [ ] Schema updated (if necessary)

e82eric avatar Aug 09 '24 06:08 e82eric

Sorry for the delay! We've been understaffed this week 🙂

DHowett avatar Aug 16 '24 23:08 DHowett

No worries, no rush on my end.

e82eric avatar Aug 17 '24 15:08 e82eric

Thanks for being so patient with us. Sorry it's taken us a long time to get to it.

Got a chance to discuss this with the team. We're interested in being able to open the settings directory, but not the sendInput or clipboard ones as they may be too niche.

Sounds good! updated.

e82eric avatar Oct 22 '24 01:10 e82eric

Gif removed from PR body:

open_settings_in_explorer

carlos-zamora avatar Oct 29 '24 18:10 carlos-zamora

Was there a reason why we didn't merge this?

lhecker avatar Dec 04 '24 00:12 lhecker

/azp run

carlos-zamora avatar Dec 04 '24 22:12 carlos-zamora

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 04 '24 22:12 azure-pipelines[bot]