terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Unable to delete profiles in Terminal

Open mridun-gupta opened this issue 2 years ago • 20 comments

Windows Terminal version

1.17.11461.0

Windows build number

No response

Other Software

No response

Steps to reproduce

1.) Make a custom terminal profile 3.) Try deleting it, it shows the option to delete

Expected Behavior

The profile should be deleted by the backend OS smoothly.

Actual Behavior

It won't get deleted.

https://github.com/microsoft/terminal/assets/91019667/7a01252b-1e80-4181-8d68-ac38518e7434

mridun-gupta avatar Jun 13 '23 04:06 mridun-gupta

I assume this problem persists even after you restart Windows Terminal right? Could you provide us with a settings.json file that reproduces the issue?

lhecker avatar Jun 13 '23 15:06 lhecker

Yes, It persists even after restarting terminal or even Windows 11 (only happening on Windows 11, on Windows 10 working fine)

mridun-gupta avatar Jun 13 '23 15:06 mridun-gupta

settings.txt

converted json to txt (for direct code of json check history of this comment the profiles are unavailable in the json

mridun-gupta avatar Jun 13 '23 15:06 mridun-gupta

Hi @mridun-gupta. This seems to be the wrong settings file. The profiles should be in the JSON. Additionally, the "SharePoint Online Management Shell" profile is in the JSON but isn't in the video you shared.

Just to be sure, click on the "Open JSON file" button in the navigation view, then send us a copy of that one. Also, curious, do you have multiple versions of Windows Terminal installed?

carlos-zamora avatar Jun 14 '23 21:06 carlos-zamora

Hi @mridun-gupta. This seems to be the wrong settings file. The profiles should be in the JSON. Additionally, the "SharePoint Online Management Shell" profile is in the JSON but isn't in the video you shared.

Just to be sure, click on the "Open JSON file" button in the navigation view, then send us a copy of that one. Also, curious, do you have multiple versions of Windows Terminal installed?

The JSON file is correct, SharePoint Online Management Shell is added just to test whether the forum solutions might help or not, and now I unable to delete it too, SpeedTest profiles shown in shared video are not mentioned in the JSON file too (which I do mentioned while sharing JSON file.)

mridun-gupta avatar Jun 15 '23 02:06 mridun-gupta

Yes it has errors and it needs to be fixed . Do you want our help and support On Thu, Jun 15, 2023 at 3:32 AM Mridun Gupta < @.> wrote: Hi @mridun-gupta https://github.com/mridun-gupta. This seems to be the wrong settings file. The profiles should be in the JSON. Additionally, the "SharePoint Online Management Shell" profile is in the JSON but isn't in the video you shared. Just to be sure, click on the "Open JSON file" button in the navigation view, then send us a copy of that one. Also, curious, do you have multiple versions of Windows Terminal installed? The JSON file is correct, SharePoint Online Management Shell is added just to test whether the forum solutions might help or not, and now I unable to delete it too, SpeedTest profiles shown in shared video are not mentioned in the JSON file too (which I do mentioned while sharing JSON file.) — Reply to this email directly, view it on GitHub <#15542 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BASR7VRXJOJY7AJEFI4PMQLXLJX3JANCNFSM6AAAAAAZEIEDLQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

Yes, please. It will be very kind of you to help me out and try to fix the issue in future updates (if there is something messed up in the source code itself).

mridun-gupta avatar Jun 15 '23 03:06 mridun-gupta

Just so you know, that person is not affiliated with our team even though the language they used indicated that they might be.

Thanks for the additional information. Can you share the file path to that settings file? In addition, do you have multiple versions of Windows Terminal installed?

DHowett avatar Jun 15 '23 03:06 DHowett

Typically, if a profile is present in the settings interface it must be present in the JSON file. There are likely multiple novel bugs here that we have never seen reports of before. :)

DHowett avatar Jun 15 '23 03:06 DHowett

Just so you know, that person is not affiliated with our team even though the language they used indicated that they might be.

Thanks for the additional information. Can you share the file path to that settings file? In addition, do you have multiple versions of Windows Terminal installed?

Thank you for informing sir, I only use a single Windows Terminal installed on my Windows 11.

mridun-gupta avatar Jun 15 '23 03:06 mridun-gupta

Typically, if a profile is present in the settings interface it must be present in the JSON file. There are likely multiple novel bugs here that we have never seen reports of before. :)

Yeah, I had almost the same configuration earlier in Windows 10, I had no issues with it, but when I made it to Windows 11, Terminal started producing errors.

mridun-gupta avatar Jun 15 '23 03:06 mridun-gupta

Thank you, @microsoft for deleting the spammy messages.

mridun-gupta avatar Jun 15 '23 03:06 mridun-gupta

Thanks for all the info. Right now, we don't know what is happening and so the bug will require a bit more investigation.

DHowett avatar Jun 21 '23 21:06 DHowett

Just notify I have the same issue when trying to delete profiles. Terminal Version: 1.17.11461.0 Windows 10 22H2 build 19045.3208.

Limyx826 avatar Jul 22 '23 16:07 Limyx826

LocalState.zip Attached the entire local state folder for reference.

Limyx826 avatar Jul 22 '23 16:07 Limyx826

I also have this issue - is there anything I can do to provide some more information about this? 1.17.11461.0 windows 11 21H2

jtnord avatar Sep 04 '23 17:09 jtnord

I don't know if this is already known, but just mentioning this here since I noticed it.

I have Windows 10 Version 10.0.19045.3324, Terminal Version: 1.17.11461.0.

I delete a profile and it does not get deleted. So, I checked in the settings JSON file and it still contained the profile(was not removed). Only after clicking the save button did I see the profile getting deleted, which subsequently deleted the profile in the JSON file. Hitting save triggers the deletion it seems. Attached is a video for reference, in which I deleted the profile named 'Profile7'.

https://github.com/microsoft/terminal/assets/25024714/9de10c20-fe91-40ee-b616-cf24bb698c9d

codecruisedor avatar Sep 14 '23 17:09 codecruisedor

I don't know if this is already known, but just mentioning this here since I noticed it.

I have Windows 10 Version 10.0.19045.3324, Terminal Version: 1.17.11461.0.

I delete a profile and it does not get deleted. So, I checked in the settings JSON file and it still contained the profile(was not removed). Only after clicking the save button did I see the profile getting deleted, which subsequently deleted the profile in the JSON file. Hitting save triggers the deletion it seems. Attached is a video for reference, in which I deleted the profile named 'Profile7'.

Desktop.2023.09.14.-.23.06.31.01.mp4

Thank you @codecruisedor for sharing this clip, but maybe the team have either make this as a disclaimer in settings or might make it less confusing for a regular user.

mridun-gupta avatar Sep 14 '23 18:09 mridun-gupta

I think this is related to UX bugs.

It would be OK to keep the current behavior, but that in combination with the UX issues below, makes it very hard for a newbie or casual user to deal with profiles in a proper manner:

  • There is no indication in the Settings window that changes have been made, and that user needs to click on Save after deleting a profile.
  • The "Discard Changes" button is always visible and enabled, even when no changes have been made.
  • If one simply closes the setting tab, there's also no indication of pending changes, and those are simply lost.

Btw, I also struggled with the problem described by the OP, and I was only able to "fix" it by following @codecruisedor's suggestion.

rsenna avatar Jan 13 '24 17:01 rsenna

@rsenna Do you suggest that I reopen this issue again (in the public interest)?

mridun-gupta avatar Jan 15 '24 07:01 mridun-gupta

I also stumbled upon this issue-thread while looking for a solution. I experienced it exactly like described above (clip).

  • go to settings
  • select profile
  • click delete
  • confirm deletion (❗)
  • profile is removed from the settings navigation on the left (this is where the confusion comes from)

Now I closed the settings tab and from the new tab dop-down menu the profile was still available. Also when opening the settings again, the profile appeared in all menus again.

Solution: All the steps but additionally click on save in the profile settings window that is automatically selected after confirmation of deletion (which actually belongs to another profile than the one I deleted 😵)

pascal456 avatar Aug 20 '24 09:08 pascal456

Looping back on this. Closing as by design since it's a matter of clicking the "save" button.

carlos-zamora avatar Jan 15 '25 22:01 carlos-zamora