terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Merge the PrintString functionality into AdaptDispatch

Open j4james opened this issue 2 years ago • 0 comments

Summary of the Pull Request

The main purpose of this PR was to merge the ITerminalApi::PrintString implementations into a shared method in AdaptDispatch, and avoid the VT code path depending on WriteCharsLegacy. But this refactoring has also fixed some bugs that existed in the original implementations.

References

This helps to close the gap between the Conhost and Terminal (#13408).

PR Checklist

  • [x] Closes #780
  • [x] Closes #12440
  • [x] Closes #12739
  • [x] CLA signed.
  • [ ] Tests added/passed
  • [ ] Documentation updated.
  • [ ] Schema updated.
  • [x] I've discussed this with core contributors already. Issue number where discussion took place: #13408

Detailed Description of the Pull Request / Additional comments

TODO

Validation Steps Performed

TODO

j4james avatar Jan 06 '23 01:01 j4james