terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Update ProfileViewModel and AppearanceViewModel to use ColorSchemeViewModel; remove ProfilePageNavigationState

Open PankajBhojwani opened this issue 2 years ago • 0 comments

Summary of the Pull Request

ColorScheme MVVM was implemented in #13179. This PR updates the ProfileViewModel/AppearanceViewModels to use color scheme view models instead of the raw settings model objects.

  • [x] Updates ProfileViewModel/AppearanceViewModel to use ColorSchemesPageViewModel/ColorSchemeViewModel implemented in #13179
  • [x] Removes ProfilePageNavigationState

PR Checklist

  • [ ] Closes #xxx
  • [x] CLA signed. If not, go over here and sign the CLA
  • [ ] Tests added/passed
  • [ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • [ ] Schema updated.
  • [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Settings UI still works (we probably want to bug bash this at some point though as with all SUI changes)

PankajBhojwani avatar Dec 16 '22 21:12 PankajBhojwani