terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

[SUI] Polish Launch Parameters setting controls

Open carlos-zamora opened this issue 2 years ago • 4 comments

Summary of the Pull Request

Performs some cleanup in the Settings UI for the Launch Parameters settings:

  1. Updates all NumberBox controls in the Settings UI to have a Compact SpinButtonPlacementMode instead of an inline one. This alleviates the XAML bug where the spin button would appear over the number box's input value.
  2. Fixes an issue where a long X/Y value would resize the settings controls weirdly. This was fixed by introducing a Grid inside the main grid and applying a width to the number boxes.
  3. Rename "Use system default" checkbox to be more clear. Propagate the new localized string into expander preview.

Closes #14558

carlos-zamora avatar Dec 15 '22 18:12 carlos-zamora

Launch Params Fix

EDIT: I'm too lazy to recapture this gif, but we've now renamed the checkbox string

carlos-zamora avatar Dec 15 '22 18:12 carlos-zamora

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

zadjii-msft avatar Dec 15 '22 18:12 zadjii-msft

Should we also have the (Default, Default) text in the expando replaced with "Let system position window"

Ask and you shall receive: image

Tested with resizing the window too. Nothing gets cropped.

carlos-zamora avatar Dec 15 '22 19:12 carlos-zamora

"let system position window, centered" is a funny juxtaposition. In that specific case, it means "Let system select which monitor" (but we should phrase it better...)

DHowett avatar Dec 15 '22 23:12 DHowett

@msftbot merge this in 10 minutes

carlos-zamora avatar Dec 16 '22 20:12 carlos-zamora

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 16 Dec 2022 20:58:21 GMT, which is in 10 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

ghost avatar Dec 16 '22 20:12 ghost

:tada:Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

ghost avatar Jan 24 '23 18:01 ghost