[1.17] Setting the $theme.tabRow.background to `#00000000` results in double titlebar

[carlos-zamora]

[zadjii-msft]

GAH GOD I thought I fixed that. Regressed probably in the last few commits of #13935

[zadjii-msft]

Uh shoot I'm not seeing this

That's on 1.17.3481.0.

Maybe I need a different set of settings?

[DHowett]

So, I've noticed that I only see this after a settings reload... or sometimes when locking/unlocking my workstation. There's some interplay between the different window styles we go through on the way to "no titlebar."

[zadjii-msft]

what settings tho

[DHowett]

This is all I've got in the themes department:

    "theme": "Cool Things",
    "themes": 
    [
        {
            "name": "Cool Things",
            "tab": 
            {
                "background": "terminalBackground",
                "showCloseButton": "always",
                "unfocusedBackground": null
            },
            "tabRow": 
            {
                "background": "#00000000",
                "unfocusedBackground": null
            }
        }
    ],
    "alwaysShowTabs": true,
    "showTabsInTitlebar": true,

[zadjii-msft]

FUDGE okay, that does repro for me, with

I'll figure that out. I bet there's a weird interaction between the #00000000 and the null

[zadjii-msft]

Yep, that's what does it.

If the window is inactive when the settings are changed, the NCIW will use the current TitlebarBrush to determine if we need to totally obscure the titlebar or not. For this theme, the ThemeColor is null, so the NCIW evaluates that as opaque, so it decides it's fine to have a titlebar.

Easiest way to do this is probably expose another property out of applogic to make this easy.

[DHowett]

Thanks for digging through my bad bug reports haha

[ghost]

:tada:This issue was addressed in #14708, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

• Release Notes
• Store Download