`Always show tabs` not toggleable in SUI

[elsaco]

Windows Terminal version

1.16.2523.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

Open Appearance in SUI and select Always show tabs

Expected Behavior

Always show tabs option to be toggleable

Actual Behavior

Control is grayed out and set to On:

[DHowett]

You cannot turn off the display of tabs while "show tabs in titlebar" is turned on.

[zadjii-msft]

We probably should have some sub-text that appears when in this case to indicate why it's forced on. Or at least additional text that clarifies "This setting cannot be disabled while 'Hide the titlebar' is enabled."

[elsaco]

Thank you @DHowett. I wouldn't have guessed that Hide the title bar needs to be off before Always show tabs control becomes active. Some clue in the SUI would be helpful, as suggested by @zadjii-msft

[BenConstable9]

Looking at how PowerToys handles a scenario like this:

Would this be acceptable? If so, happy to make PR.

[DHowett]

@BenConstable9 I love your suggestion - sorry, I never said that and let this thread go dark - and it fits in with how we're going to pivot title bar appearance into the theming UI in the future.

I'd love to see how it turns out if you do choose to PR it.

[jamespack]

Adding text is easy enough.

[jamespack]

Happy to PR it if you are good with that verbiage

[DHowett]

Works for me!

We may want to note in the <comment> for that translation that it is referring to another setting (and include the localization key for that setting too)

[jamespack]

Ok PR opened.