terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Stop writing optional theme fields

Open lhecker opened this issue 3 years ago • 0 comments
trafficstars

Other settings model classes call JsonUtils::SetValueForKey with the private _##value member as the value. Since _##value is an optional, this prevented writing out unset, optional fields. The new Themes class deviated from this and this commit brings it back in line with the others.

Closes #13544

Validation Steps Performed

  • Create a { "name": "test" } theme
  • Save settings via the UI
  • Optional/Defaulted fields aren't written ✅

lhecker avatar Aug 09 '22 00:08 lhecker

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

msftbot[bot] avatar Aug 10 '22 20:08 msftbot[bot]

:tada:Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

msftbot[bot] avatar Sep 13 '22 17:09 msftbot[bot]