terminal
terminal copied to clipboard
Stop writing optional theme fields
trafficstars
Other settings model classes call JsonUtils::SetValueForKey with the
private _##value member as the value. Since _##value is an optional,
this prevented writing out unset, optional fields. The new Themes class
deviated from this and this commit brings it back in line with the others.
Closes #13544
Validation Steps Performed
- Create a
{ "name": "test" }theme - Save settings via the UI
- Optional/Defaulted fields aren't written ✅
Hello @zadjii-msft!
Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.
p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
:tada:Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:
Handy links: