terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Font features break line drawing

Open registerGen opened this issue 3 years ago • 6 comments
trafficstars

Windows Terminal version

1.15.2003.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

Modify the config file as below:

image

Expected Behavior

Unicode isn't broken.

image

Actual Behavior

image

registerGen avatar Aug 03 '22 08:08 registerGen

The font can be downloaded from here.

registerGen avatar Aug 03 '22 08:08 registerGen

Huh. I wonder why stylistic set 0 would break line drawing like that. Maybe we're just disabling the scaling for line drawing characters whenever a stylistic set is picked? Or maybe ss01 in Delugia has the line drawing characters specifically drawn to avoid merging them across lines.

I wonder if this repros for the Cascadia family, or any other fonts...

zadjii-msft avatar Aug 03 '22 11:08 zadjii-msft

I tried many stylistic sets of Cascadia Code and Delugia, this all repro-ed.

But if Fira Code is used, this won't happen.

registerGen avatar Aug 03 '22 12:08 registerGen

Unless I'm testing incorrectly, this issue doesn't seem to occur with AtlasEngine, after #13549.

lhecker avatar Aug 06 '22 01:08 lhecker

Well this issue still occurs in the latest release yesterday, but the "gap" is much unnoticeable now.

image

registerGen avatar Sep 14 '22 13:09 registerGen

I'm glad it's much better! Very slight gaps are something I've also noticed myself for fonts that aren't particularly pixel-perfect, but I haven't had time to investigate it further yet. This is the worst that I could produce myself (magnified 400%): image

Yours seem to be the exact same kind, which means I can reproduce and thus hopefully fix it.

lhecker avatar Sep 14 '22 13:09 lhecker