terminal icon indicating copy to clipboard operation
terminal copied to clipboard

Make Mark Mode keybindings precede custom keybindings

Open carlos-zamora opened this issue 3 years ago • 1 comments
trafficstars

Summary of the Pull Request

This PR moves the key handling for mark mode into a helper method that is then called before an action/key binding is attempted.

References

Epic: #4993 Closes #13533

Validation Steps Performed

  • Add custom keybinding to "down" arrow key
  • in mark mode --> selection updates appropriately
  • out of mark mode --> keybinding executed

carlos-zamora avatar Aug 02 '22 19:08 carlos-zamora

Hmm... I'm marking this as a service-able bugfix. But if anybody disagrees, let me know.

carlos-zamora avatar Aug 02 '22 20:08 carlos-zamora

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost avatar Aug 22 '22 20:08 ghost

:tada:Windows Terminal v1.15.252 has been released which incorporates this pull request.:tada:

Handy links:

ghost avatar Sep 13 '22 17:09 ghost

:tada:Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

ghost avatar Sep 13 '22 17:09 ghost