terminal icon indicating copy to clipboard operation
terminal copied to clipboard

[1.16] Default theme updates

Open zadjii-msft opened this issue 3 years ago • 2 comments
trafficstars

From discussion with @cinnamon-msft et. al.

  • [ ] Dark theme by default (was system)
  • [ ] tab.background: terminalBackground
  • [ ] Change the tab row colors back to what they were pre-Controlsv2
    • This point I might be mis-remembering. I think the crux was "make the colors better", and we had freedom to do whatever we wanted.
    • The current dark tabRow.background is basically the same as the default scheme BG, and maybe that's good, maybe that's bad.
  • [ ] tabRow.unfocusedBackground set to something sensible in the default themes as well.

The 🌶️ rejected ides:

  • Default to mica on
    • Rejected cause this would disable vintage opacity
    • Rejected cause our Mica story isn't fleshed out yet
    • Rejected cause dark tabs in light OS theme with Mica titlebars has pretty low contrast overall.
  • ... with a non-acrylic, transparent control, so that you'd get the mica termcontrol body.
    • see all the above.

zadjii-msft avatar Jul 21 '22 11:07 zadjii-msft

🏗️ Work in progress 🏗️

originscreenshot (focused/unforcused if available)tab.backgroundtabRow.backgroundtabRow.unfocusedBackgroundWith terminalBackground & CampbellContrast (goal 3:1)
Edge Dark

image image

(1.454:1 / 1.212:1)

#3b3b3b

#202020

#2e2e2e

image image

1.2:1 / 1.44:1
Terminal (Controlsv1)

image

#0c0c0c

#333333

n/a

image

1.548:1
Terminal (Controlsv2)

image

(1.342:1)

#282828

#0a0a0a

n/a

image

1.012:1
BG from edge unfocused,

inactive BG from controlsv1

n/a

terminalBackground

#2e2e2e

#333333

image

image

1.44:1 / 1.548:1
Light BG from edge unfocused,

inactive BG from controlsv1

n/a

terminalBackground

#e8e8e8

#ffffff

15.9:1

Notes:

  • Campbell's BG is #0c0c0c

zadjii-msft avatar Aug 05 '22 15:08 zadjii-msft

:tada:This issue was addressed in #13743, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

ghost avatar Sep 13 '22 17:09 ghost