snmalloc icon indicating copy to clipboard operation
snmalloc copied to clipboard

Add _base variants of Windows Heap API, partially close #638

Open Naville opened this issue 2 years ago • 4 comments

I'm still not quite sure how the _recalloc implementation works so I kept that part out

Naville avatar Oct 10 '23 03:10 Naville

Thanks for doing this. I think your branch is a bit behind main. In particular, I think it is behind #624 which refactored this code to be a bit cleaner. Would you be change in line with that? Thanks

mjp41 avatar Oct 10 '23 08:10 mjp41

Do you have a link to the documentation for these? I could not find them on MSDN.

davidchisnall avatar Oct 10 '23 08:10 davidchisnall

Documentation on this is hard to come by. When I have talked to people they have been unkeen to officially support anything, but they try not to break the tricks other people are using.

PartititonAlloc provides these: https://source.chromium.org/chromium/chromium/src/+/main:base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_ucrt_symbols_win.h

mjp41 avatar Oct 10 '23 08:10 mjp41

Do you have a link to the documentation for these? I could not find them on MSDN.

In my use case, without these variants the linker still tries to pull them in from ucrt, which results in duplicate definition error

Naville avatar Oct 10 '23 10:10 Naville