sbom-tool icon indicating copy to clipboard operation
sbom-tool copied to clipboard

refactor: replace Serilog.ILogger with Microsoft.Extensions.Logging.ILogger<T>

Open sebasgomez238 opened this issue 1 year ago • 1 comments

sebasgomez238 avatar Dec 22 '23 21:12 sebasgomez238

Codecov Report

Attention: Patch coverage is 52.22930% with 75 lines in your changes missing coverage. Please review.

Project coverage is 59.78%. Comparing base (8d19e9f) to head (69710da). Report is 317 commits behind head on main.

Files with missing lines Patch % Lines
...icrosoft.Sbom.Api/Output/MetadataBuilderFactory.cs 0.00% 8 Missing :warning:
...oft.Sbom.Api/Output/Telemetry/TelemetryRecorder.cs 42.85% 7 Missing and 1 partial :warning:
...ft.Sbom.Api/Executors/LicenseInformationService.cs 0.00% 5 Missing :warning:
src/Microsoft.Sbom.Api/Output/MetadataBuilder.cs 28.57% 5 Missing :warning:
...Api/Workflows/SBOMParserBasedValidationWorkflow.cs 42.85% 4 Missing :warning:
...Sbom.Api/Executors/ComponentDetectionBaseWalker.cs 25.00% 3 Missing :warning:
...kageDetails/ComponentDetailsUtils/RubyGemsUtils.cs 50.00% 3 Missing :warning:
...t.Sbom.Api/PackageDetails/PackageDetailsFactory.cs 0.00% 3 Missing :warning:
...Providers/FilesProviders/FileToJsonProviderBase.cs 0.00% 3 Missing :warning:
...osoft.Sbom.Api/Workflows/SBOMGenerationWorkflow.cs 72.72% 3 Missing :warning:
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   59.82%   59.78%   -0.04%     
==========================================
  Files         248      248              
  Lines        7561     7545      -16     
  Branches      901      899       -2     
==========================================
- Hits         4523     4511      -12     
+ Misses       2626     2622       -4     
  Partials      412      412              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 22 '23 22:12 codecov-commenter

This is a really old draft PR for an issue that has been tabled. Closing the PR and if/when we ever decide to pick this up, we'll still have the PR

DaveTryon avatar Feb 21 '25 23:02 DaveTryon