retina icon indicating copy to clipboard operation
retina copied to clipboard

fix: add secondary IPs for enrichment

Open FZhg opened this issue 1 year ago • 3 comments

Description

Please provide a brief description of the changes made in this pull request.

Related Issue

Fixes #224

Checklist

  • [x] I have read the contributing documentation.
  • [x] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • [x] I have correctly attributed the author(s) of the code.
  • [x] I have tested the changes locally.
  • [x] I have followed the project's style guidelines.
  • [x] I have updated the documentation, if necessary.
  • [x] I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image

Additional Notes

Both the previous implementation and this PR don't clear stale IP-endpoint bindings immediately from the ipToEpKey Map. E.g. When endpoint A changes from IP address "1.1.1.1" to "2.2.2.2", the stale binding between the IP address "1.1.1.1" and endpoint A is still in the ipToEpKey map until the IP address "1.1.1.1" gets reassigned to another pod. However, this shouldn't be a problem. The DNS is supposed to provide up-to-date IP addresses for the sender and receiver so that any flow event will always contain the latest IP addresses.

FZhg avatar Apr 16 '24 12:04 FZhg

@rbtr Hi Evan, Could you give me another approval for running the CI tests? Thanks!

FZhg avatar Apr 17 '24 22:04 FZhg

hey @FZhg it looks like your branch has conflicts, can you resolve them? Please update it against latest main also, your diff is showing other changes than just yours and I think a rebase (git fetch --all && git rebase upstream/main or equivalent based on your repository config) would resolve this.

rbtr avatar Apr 17 '24 22:04 rbtr

hey @FZhg it looks like your branch has conflicts, can you resolve them? Please update it against latest main also, your diff is showing other changes than just yours and I think a rebase (git fetch --all && git rebase upstream/main or equivalent based on your repository config) would resolve this.

Thanks for your help! Problem solved.

FZhg avatar Apr 18 '24 00:04 FZhg

lgmt, thank you for your contribution

snguyen64 avatar Apr 24 '24 18:04 snguyen64