react-native-windows
react-native-windows copied to clipboard
microsoft
Standardize hermes packaging
Problem Description
Package is unsigned, not named based on convention and uploaded from private credentials.
Steps To Reproduce
Notice the packages.config
Expected Results
Hermes package is
- Named as Microsoft.*
- Signed
- Published by proper user agents
CLI version
npx react-native --version
Environment
npx react-native info
Target Platform Version
No response
Target Device(s)
No response
Visual Studio Version
No response
Build Configuration
No response
Snack, code example, screenshot, or link to a repository
No response
@mganandraj FYI in the future you can use either the feature request template or the empty issue template for when the bug template is a bad fit.
Multiple issues tracked here. This one would be a change to the template that we would want to frontload:
not named based on convention
There's some setup in this repo for signing that may not be available in Hermes repo (https://github.com/microsoft/hermes-windows). So where this work happens will affect how straightforward this is.
@dedavis6797 Is this on your radar for the Hermes work? With RN 0.69 including Hermes, is this the right time to get our version of Hermes synced nicely with RNW 0.69?
Can you assign this to the right person?
@dedavis6797 Does this need to be addressed for the Hermes rollout in 0.70?
Flagging to discuss if issue should remain prioritized / what are next steps as issue has been punted 2 releases.
Is now being signed properly. Name change is the only remaining part of this. (will also involve making sure the account it's published under can publish that) People who probably best know how to do this: @dannyvv and @jonthysell
Name: Microsoft.Hermes
Question: Do we need separate for Win32 vs. UWP? Today we only release for UWP. May change in the future.
@vmoroz is going to take a look to get the first steps started