react-native-windows
react-native-windows copied to clipboard
Build failure due to the warning in the new file in upstream
Problem Description
https://github.com/facebook/react-native/blob/c31ff55b922502edfbbe21576e583051b3fcd0ac/packages/react-native/ReactCommon/react/renderer/core/DynamicEventPayload.cpp#L39
Link to the integration PR where the error originated
https://github.com/microsoft/react-native-windows/pull/14791
Link to react-native commit
https://github.com/facebook/react-native/commit/9d7cdfef178037b276c5bfb9665eeaa6550c5c41
Forked files
No response
Upstream PR in react-native
No response
Build Configuration
None
@vineethkuttan Do you know when the upstream issue will be resolved and thus when this needs to be handled in future integrations? Is there a fork in place for this or is it a pending codeflow from Meta?
@vineethkuttan Can you share the build warning text here?
We were facing a type conversion error: the function returns std::optional<double
I couldn't find any PR for that, we have to fix it in React native repo.
Will do it, add the PR link here.
https://github.com/microsoft/react-native-windows/blob/d9bd9b2d9125dca833c7b1268f4f0497e95c79a3/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/core/DynamicEventPayload.cpp#L36-L36
Add the above line to the std::optional<double
The pr got merged on 11/7 in react native's repo