react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Build failure due to the warning in the new file in upstream

Open vineethkuttan opened this issue 5 months ago • 2 comments

Problem Description

https://github.com/facebook/react-native/blob/c31ff55b922502edfbbe21576e583051b3fcd0ac/packages/react-native/ReactCommon/react/renderer/core/DynamicEventPayload.cpp#L39

Link to the integration PR where the error originated

https://github.com/microsoft/react-native-windows/pull/14791

Link to react-native commit

https://github.com/facebook/react-native/commit/9d7cdfef178037b276c5bfb9665eeaa6550c5c41

Forked files

No response

Upstream PR in react-native

No response

Build Configuration

None

vineethkuttan avatar Jun 18 '25 07:06 vineethkuttan

@vineethkuttan Do you know when the upstream issue will be resolved and thus when this needs to be handled in future integrations? Is there a fork in place for this or is it a pending codeflow from Meta?

chrisglein avatar Jun 19 '25 16:06 chrisglein

@vineethkuttan Can you share the build warning text here?

chrisglein avatar Jun 19 '25 16:06 chrisglein

We were facing a type conversion error: the function returns std::optional<double>, but code returning dynamic.asInt().

I couldn't find any PR for that, we have to fix it in React native repo.

Will do it, add the PR link here.

vineethkuttan avatar Jul 08 '25 15:07 vineethkuttan

https://github.com/microsoft/react-native-windows/blob/d9bd9b2d9125dca833c7b1268f4f0497e95c79a3/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/core/DynamicEventPayload.cpp#L36-L36

Add the above line to the std::optional<double> DynamicEventPayload::extractValue() in DynamicEventPayload.cpp in React Native repo, and link the PR in comment.

vineethkuttan avatar Jul 08 '25 15:07 vineethkuttan

The pr got merged on 11/7 in react native's repo

HariniMalothu17 avatar Jul 15 '25 09:07 HariniMalothu17