react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Remove C++20 Patches from ReactCommon Files

Open chiaramooney opened this issue 2 years ago • 2 comments

Remove patches needed because RN is on C++20 and we use a lower version. Patches were made to ShadowTree.cpp, NumericBitfield.cpp, Config.h, LayoutResults.h, UIMangerBinding.cpp, and Node.h.

chiaramooney avatar Sep 29 '23 17:09 chiaramooney

Related:

  • https://github.com/microsoft/react-native-windows/issues/7748
  • https://github.com/microsoft/react-native-windows/issues/7774

Need to make a decision on whether we update this for 0.73. Doesn't seem like there's a reason for us to not match core and use this latest. Just need to make sure any customers who can't make that move have a clear path.

chrisglein avatar Oct 02 '23 17:10 chrisglein

Added RawPropsParser.cpp and propsConversion.h from the PR https://github.com/facebook/react-native/pull/41149/files

TatianaKapos avatar Dec 22 '23 22:12 TatianaKapos

@chiaramooney Can you check the forking status of these files given the integration payload for the past couple months?

chrisglein avatar Apr 09 '24 20:04 chrisglein

Closing, check with main and these files are unforked :)

  • ShadowTree.cpp
  • NumericBitfield.cpp
  • Config.h
  • LayoutResults.h
  • UIMangerBinding.cpp
  • Node.h
  • RawPropsParser.cpp
  • propsConversion.h

TatianaKapos avatar Jun 11 '24 18:06 TatianaKapos