react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

NativeAnimated module behavior difference for medium complexity animation

Open rozele opened this issue 3 years ago • 2 comments
trafficstars

Problem Description

We noticed a bug during the upgrade to 0.68 where composition animations stopped working correctly for a specific component.

I didn't spend any time isolating where the bug is coming from in NativeAnimated, but instead just ported the component over so anyone can reproduce the bug.

Steps To Reproduce

  1. Pull in changes from https://github.com/rozele/react-native-windows/commit/8115d05f6904d412d3fdb242de31c68f9effdc9a
  2. Run Playground app
  3. Load Samples\simple example in Playground
  4. Play around with the "star rating" component, notice the difference when running the JS driven animation and after clicking the Use Native Driver button to enable native animations.

Expected Results

NativeAnimated behavior should be identical to JS driven animation behavior.

CLI version

npx react-native --version

Environment

npx react-native info

Target Platform Version

No response

Target Device(s)

No response

Visual Studio Version

No response

Build Configuration

No response

Snack, code example, screenshot, or link to a repository

No response

rozele avatar Aug 03 '22 17:08 rozele

In case this helps in debugging, this scenario actually used to work fine with Composition in v0.63 - only started seeing issues in 0.68.

rozele avatar Aug 03 '22 18:08 rozele

where composition animations stopped working correctly for a specific component.

Can you briefly capture what the difference is you're seeing? Text or video, just so it's captured here.

We've previously talked about the difference between behavior of composition animations vs. JS expectations and how we may want to add an opt-out switch for a slower path that offers complete compatibility. I'm guessing this is another scenario that would be helped by that.

chrisglein avatar Aug 04 '22 18:08 chrisglein