react-native-windows
react-native-windows copied to clipboard
microsoft
Adds QuirkSetting to always use sqlite3 for AsyncStorage
Description
Type of Change
Erase all that don't apply.
- New feature (non-breaking change which adds functionality)
Why
Currently, apps with package identity default to using Windows.Storage files for AsyncStorage, but these apps may want the option to opt in to the sqlite3 implementation.
Resolves #10312
What
This commit adds a quirk setting to enable opt-in to sqlite3 storage.
Microsoft Reviewers: Open in CodeFlow
Open to other options, I'll likely also be proposing another setting to customize the path where the AsyncStorage DB goes in a separate PR.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
FYI AsyncStorage was removed in 0.71. So, we should probably be deleting the whole module. The JS code has already been removed.
This PR had approval, but given that AsyncStorage is being removed in the current release of 0.71, is this PR still needed? @rozele thoughts?
@chrisglein - up to you. We're going to have to start thinking about migration, but given our app has always been on the sqlite AsyncStorage, this won't be much of a problem. This change might still be useful if you wanted to cherry-pick it back to v0.70 and complement it with something that does StorageFile -> sqlite background migration to smooth out migration. Fine with me to close, as we won't be needing this commit post-migration.