react-native-windows-samples icon indicating copy to clipboard operation
react-native-windows-samples copied to clipboard

Add Fabric Component Props under API and Separate Old/New Components Section

Open anupriya13 opened this issue 7 months ago • 4 comments

Description

  • Separates Old and New Arch Components Sections
  • Adds Fabric Component Props under New API for Windows. It doesn't contain Android / IOS specific props.

Why

What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits. Improve documentation

Resolves https://github.com/microsoft/react-native-windows-samples/issues/1025

Refer https://github.com/facebook/react-native-website/blob/main/docs/image.md?plain=1

Screenshots

Add any relevant screen captures here from before or after your changes. Before:

https://github.com/user-attachments/assets/94f2d14c-efef-42ea-8453-41f29ec543af

After: Added a new section which was missing in before "Windows Components - New Architecture"

https://github.com/user-attachments/assets/483051c1-5050-4259-8b26-25ed13765629

Microsoft Reviewers: Open in CodeFlow

anupriya13 avatar Apr 18 '25 08:04 anupriya13

@microsoft-github-policy-service agree company="Microsoft"

anupriya13 avatar Apr 18 '25 09:04 anupriya13

Couple of small things:

  • In the sidebar, the titles of the Old and New Arch sections could be changed to just be 'Components - New Architecture' and 'Components - Old Architecture'. The 'Windows' part is not necessary since it's the React Native for Windows website.
  • Some of the components that you have put in the New Architecture section are also present in Old Architecture, which may cause some confusion for newer users of React Native Windows. Maybe it might make sense to have a list of Core components that are present in (or planned to be present in) both Old and New Architecture, and then a section for Old Arch only components, and one for New Arch only components.

Yajur-Grover avatar Apr 18 '25 16:04 Yajur-Grover

Couple of small things:

  • In the sidebar, the titles of the Old and New Arch sections could be changed to just be 'Components - New Architecture' and 'Components - Old Architecture'. The 'Windows' part is not necessary since it's the React Native for Windows website.
  • Some of the components that you have put in the New Architecture section are also present in Old Architecture, which may cause some confusion for newer users of React Native Windows. Maybe it might make sense to have a list of Core components that are present in (or planned to be present in) both Old and New Architecture, and then a section for Old Arch only components, and one for New Arch only components.
  1. Sure, will update the titles, as this doc is for Mac as well hence will keep Windows.
  2. The reason I kept it as different is because each page of old and new would have different props, and when we want to depreciate the old one it would be easier. Helps us track exactly what props are implemented. Also, the old arch documentation is not complete, wouldn't want to add effort in updating that. Hence, keeping these 2 separate only for now. We can update in future after discussing with PMs.

anupriya13 avatar Apr 19 '25 06:04 anupriya13

  1. The reason I kept it as different is because each page of old and new would have different props, and when we want to depreciate the old one it would be easier. Helps us track exactly what props are implemented. Also, the old arch documentation is not complete, wouldn't want to add effort in updating that. Hence, keeping these 2 separate only for now. We can update in future after discussing with PMs.

Okay, maybe we can apply the suggestion from https://github.com/microsoft/react-native-windows-samples/issues/1014 then, and mark each page depending on whether it is applicable to Old Arch, New Arch or both.

Yajur-Grover avatar Apr 21 '25 04:04 Yajur-Grover