react-native-code-push icon indicating copy to clipboard operation
react-native-code-push copied to clipboard
verified publisher icon microsoft

CodePush does not work if CODE_PUSH_APK_BUILD_TIME is inside a DFM

Open saihemanth121 opened this issue 3 years ago • 1 comments

Platform: Android

I have an Android Project where react-native components are part of a Dynamic Feature Module (DFM). CodePush works if CODE_PUSH_APK_BUILD_TIME is added as resValue to defaultConfig in base module. But it affects incremental builds and build caching since it changes every build, so I tried moving it to the DFM where all other react-native components are along with codepush dependency. This breaks codepush as CodePush.java is using base package name (instead of DFM package name) to get the resource identifier for CODE_PUSH_APK_BUILD_TIME.

Is there any other way to keep CODE_PUSH_APK_BUILD_TIME out of base module?

saihemanth121 avatar Jul 25 '22 12:07 saihemanth121

Hi @saihemanth121, Does code push supports react native version 0.68.1. Because as per the documentation only these versions are mentioned

image

geekyoperand avatar Jul 26 '22 22:07 geekyoperand

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

ghost avatar Sep 25 '22 01:09 ghost

This issue will now be closed because it hasn't had any activity for 15 days after stale. Please feel free to open a new issue if you still have a question/issue or suggestion.

ghost avatar Oct 10 '22 06:10 ghost