qsharp icon indicating copy to clipboard operation
qsharp copied to clipboard

Review algorithm samples and see if anything suspicious with global phase shows up.

Open swernli opened this issue 1 year ago • 1 comments
trafficstars

See #1317 for more context.

Some of our samples might use patterns that interact poorly with global phase in a way that can confuse readers of the state dumps. We should review the samples and see if any changes like the qubit scoping for #1370 can mitigate that confusion. In general, samples should avoid nuanced global phase if possible.

This review may result in sub-issues for relevant sample updates or just be closed once samples have been sufficiently reviewed.

swernli avatar Apr 15 '24 16:04 swernli

I skimmed through our algorithms samples, the next most confusing one is Teleportation: it says teleporting one-qubit state but DumpMachine has two qubits. We should be able to use DumpRegister instead to have one-qubit states.

tcNickolas avatar Apr 16 '24 17:04 tcNickolas

Given we have not observed any new phase issues with samples, I'm going to close this issue. We can either reopen or file fresh if a new phase related issue is seen.

swernli avatar Jul 25 '24 17:07 swernli