playwright
playwright copied to clipboard
fix(ui): respect --output param
Closes https://github.com/microsoft/playwright/issues/32331
We're already passing the outputDir param to the UI, but the UI isn't passing it back to the TestServer. This PR fixes that. I've added it to listTests, which is requires to that TestServerDispatcher#_ignoredProjectOutputs is populated with the correct output dir. And i've added it to runGlobalSetup, which is what the bug report was about.
Test results for "tests 1"
1 failed :x: [playwright-test] › babel.spec.ts:135:5 › should not transform external
4 flaky
:warning: [chromium-library] › library/trace-viewer.spec.ts:1027:1 › should serve overridden request:warning: [playwright-test] › ui-mode-test-setup.spec.ts:22:5 › should run global setup and teardown
:warning: [playwright-test] › ui-mode-test-source.spec.ts:68:5 › should show top-level errors in file
:warning: [playwright-test] › ui-mode-test-source.spec.ts:104:5 › should show syntax errors in file
30125 passed, 859 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:
Merge workflow run.
Does this fix it for both setup and teardown?
I think so, but i can also add another test to prove that.
Does this fix it for both setup and teardown?
It does: https://github.com/microsoft/playwright/pull/32351/commits/8f4b6209d331fc2ace727199e3ee719e0b8c09b7
Test results for "tests 1"
2 failed :x: [playwright-test] › babel.spec.ts:135:5 › should not transform external :x: [playwright-test] › ui-mode-test-setup.spec.ts:22:5 › should run global setup and teardown
2 flaky
:warning: [playwright-test] › ui-mode-test-source.spec.ts:68:5 › should show top-level errors in file:warning: [playwright-test] › ui-mode-test-source.spec.ts:104:5 › should show syntax errors in file
30120 passed, 859 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:
Merge workflow run.
Test results for "tests 1"
1 failed :x: [playwright-test] › babel.spec.ts:135:5 › should not transform external
3 flaky
:warning: [playwright-test] › ui-mode-test-setup.spec.ts:22:5 › should run global setup and teardown:warning: [playwright-test] › ui-mode-test-source.spec.ts:68:5 › should show top-level errors in file
:warning: [playwright-test] › ui-mode-test-source.spec.ts:104:5 › should show syntax errors in file
30120 passed, 859 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:
Merge workflow run.