playwright-dotnet icon indicating copy to clipboard operation
playwright-dotnet copied to clipboard

[Feature] Add Retries

Open mxschmitt opened this issue 3 years ago • 21 comments

Retries got reverted since there were bugs in it which would prevent users from using it efficiently.

Open items:

  • Make sure it works with timeouts
  • Make sure SetUp and TearDown runs as expected
  • Add more tests for edge cases
  • Revert https://github.com/microsoft/playwright-dotnet/pull/2315
  • Revert https://github.com/microsoft/playwright/commit/59c32bf2c6470645e9903eb7903425dcc4cf23f8

mxschmitt avatar Sep 14 '22 21:09 mxschmitt

Really looking forward into this - we are missing retries at this moment

bheemreddy181 avatar Sep 19 '22 02:09 bheemreddy181

Can we also make retries differ based on the tag - like say if we have API tests then set retries to 0 and set retries to number n for web tests ?

bheemreddy181 avatar Sep 19 '22 02:09 bheemreddy181

Retries would be for the whole project, so you can define <Retries>1</Retries> inside your runsettings file or when defining it via --settings to dotnet test. This is the same way how it's done for Node.js.

Just a question out of curiosity, are you using NUnit or MSTest?

mxschmitt avatar Sep 19 '22 10:09 mxschmitt

We are using Nunit - makes sense you can ignore the tag request. It’s better to have different run settings for different tag runs

bheemreddy181 avatar Sep 19 '22 12:09 bheemreddy181

Looking forward to this one too.

nicolaiarocci avatar Mar 21 '23 08:03 nicolaiarocci

Is there any ETA about this one?

masaplecas avatar Mar 27 '23 11:03 masaplecas

Any update on this, it will really help where tests at times fail duty flakey backend

DavinderZilo avatar Mar 30 '23 18:03 DavinderZilo

Is there any news on this? We're enjoying using playwright-dotnet a lot but retries would save us a lot of effort on manually re-running tests that fail due to random failures.

ArcadeMode avatar Aug 29 '23 08:08 ArcadeMode

Really would appreciate if we'd get some info on this. I see PlaywrightSettingsProvider has Retries option, but it doesn't work.

autom3tion avatar Nov 09 '23 09:11 autom3tion

Is there an ETA yet? Would be a great feature to have.

TheJackGower avatar Dec 11 '23 13:12 TheJackGower

Dotnet is lagging compared to nodejs in many perspective. Can we please bring it to speed and bring on these features

gauravkhuraana avatar Feb 29 '24 07:02 gauravkhuraana

Do we have any timescales for when this might be looked at again? It appears to be a popular issue and would be a big help to a lot of users.

ashleybissell avatar Apr 10 '24 07:04 ashleybissell

Is there any plan for this feature? It would be nice to have it.

ertiusmeo avatar May 29 '24 13:05 ertiusmeo

@ertiusmeo we are actively exploring options for NUnit and MSTest and collaborate with the MSTest maintainers. (no eta unfortunately)

mxschmitt avatar May 29 '24 14:05 mxschmitt