onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

[Nuget] Add netstandard* to buildTransitive folders (microsoft#17010)

Open decriptor opened this issue 1 year ago • 10 comments

The netstandard2.0 folder was added to the build folder, but not the buildTransitive folder. This means that packages like Microsoft.ML.OnnxRuntime aren't being included as transitive build dependencies.

For example, if I have a nuget of my MyLibrary which has a dependency on Microsoft.ML.OnnxRuntime and someone adds MyLibrary to their application their application would not pull in the Microsoft.ML.OnnxRuntime nuget. This manifests when the application is run and there is a onnxruntime not found error.

NOTE: I was NOT able to build packages so I couldn't test this out. Any feedback would be much appreciated.

fixes #17010

decriptor avatar Jan 23 '24 19:01 decriptor

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

tianleiwu avatar Apr 05 '24 13:04 tianleiwu

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models

tianleiwu avatar Apr 05 '24 13:04 tianleiwu

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines[bot] avatar Apr 05 '24 13:04 azure-pipelines[bot]

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

tianleiwu avatar Apr 06 '24 02:04 tianleiwu

/azp run orttraining-amd-gpu-ci-pipeline

tianleiwu avatar Apr 06 '24 02:04 tianleiwu

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 06 '24 02:04 azure-pipelines[bot]

Azure Pipelines successfully started running 10 pipeline(s).

azure-pipelines[bot] avatar Apr 06 '24 02:04 azure-pipelines[bot]

"python format" is not triggered. I will close and reopen to trigger it.

tianleiwu avatar Apr 06 '24 22:04 tianleiwu

Python format pipeline failed. Please run lintrunner -a to fix format. To set up lintrunner locally, see https://github.com/microsoft/onnxruntime/blob/main/docs/Coding_Conventions_and_Standards.md#linting

tianleiwu avatar Apr 06 '24 22:04 tianleiwu

BTW: Why are not all folders from build also in buildTransitive?

msedi avatar Jun 26 '24 05:06 msedi

@decriptor: It would be awesome if your commit would succeed. Do you think you can make it work?

msedi avatar Jul 21 '25 12:07 msedi

@msedi Sorry, I've moved on to much different projects. I think the only thing left to fix the python formatting? If you'd like to take over the changes and fix the python formatting that'd be great.

https://github.com/microsoft/onnxruntime/pull/19242#issuecomment-2041218278

decriptor avatar Jul 31 '25 02:07 decriptor

I'm going to close this out, but anyone is welcome to take these changes and finish the work.

decriptor avatar Sep 01 '25 03:09 decriptor