mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

MdeModulePkg/Core/Dxe/Gcd/Gcd.c: Add EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute.

Open apop5 opened this issue 1 year ago • 1 comments

Description

Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as per the PI 1.8 spec. This flag is used to indicate that the memory should be treated as special purpose memory (SPM).

Also adds GCD code that marks the SPM with the EFI_MEMORY_SP bit and sets the GCD memory type to EfiGcdMemoryTypeSystemMemory.

  • [x] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

N/A

Integration Instructions

N/A

apop5 avatar Jun 27 '24 23:06 apop5

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@36cb0df). Learn more about missing BASE report.

Files Patch % Lines
MdeModulePkg/Core/Dxe/Gcd/Gcd.c 0.00% 13 Missing :warning:
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #998   +/-   ##
=================================================
  Coverage                  ?    0.20%           
=================================================
  Files                     ?      628           
  Lines                     ?   218363           
  Branches                  ?      326           
=================================================
  Hits                      ?      448           
  Misses                    ?   217906           
  Partials                  ?        9           
Flag Coverage Δ
MdeModulePkg 0.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 28 '24 02:06 codecov-commenter