mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

[202405][Rebase&&FF] Firmware Performance

Open Flickdm opened this issue 1 year ago • 1 comments
trafficstars

This PR adds a series of commits intended to add firmware performance measurements to a platform.

Overview of commits:

  1. MdePkg: Add EFI_PRE_READY_TO_BOOT_GUID and EFI_POST_READY_TO_BOOT_GUID
    1. This commit adds two new GUIDS required for Delay Dispatch
  2. REBASE: Revert "MdePkg: Added header file for Delayed Dispatch PPI"
    1. This commit reverts a commit brought in from upstream that modifies the DelayDispatch.h file in MdePkg that was moved to MdeModulePkg
  3. MdeModulePkg/MdeModulePkg.dec: Adds Delay Dispatch
    1. This commit adds Delay Dispatch
  4. MdeModulePkg: Adds Performance Measurement V2
    1. This commit adds the initial performance measurements
  5. Perf-instrument PreReadyToBoot, ReadyToBoot, PostReadyToBoot signals …
    1. This commit adds the signals required for performance measurements
  6. Merged PR 5181: Change FirmwarePerformanceDxe.c EndofDxeEvent tpl to …
    1. This commit changes the TPL_NOTIFYs to TPL_CALLBACKS
  7. MdeModulePkg: PeiMain: Adds performance measurement for PeiMain
    1. Adds peformance measurements for PEI
  • [x] Impacts functionality?
  • [ ] Impacts security?
  • [ ] Breaking change?
  • [ ] Includes tests?
  • [ ] Includes documentation?

How This Was Tested

From 2311.

Flickdm avatar Jun 26 '24 21:06 Flickdm

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@9c22365). Learn more about missing BASE report.

Files Patch % Lines
MdeModulePkg/Core/Pei/PeiMain/PeiMain.c 0.00% 15 Missing :warning:
MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c 0.00% 13 Missing :warning:
MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c 0.00% 3 Missing :warning:
MdeModulePkg/Core/Dxe/Image/Image.c 0.00% 1 Missing :warning:
MdeModulePkg/Core/PiSmmCore/Dispatcher.c 0.00% 1 Missing :warning:
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c 0.00% 1 Missing :warning:
...rary/DxeCorePerformanceLib/DxeCorePerformanceLib.c 0.00% 1 Missing :warning:
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c 0.00% 1 Missing :warning:
...rePerformanceDataTableDxe/FirmwarePerformanceDxe.c 0.00% 1 Missing :warning:
MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #979   +/-   ##
=================================================
  Coverage                  ?    1.25%           
=================================================
  Files                     ?     1424           
  Lines                     ?   358662           
  Branches                  ?     4391           
=================================================
  Hits                      ?     4495           
  Misses                    ?   354106           
  Partials                  ?       61           
Flag Coverage Δ
MdeModulePkg 0.24% <0.00%> (?)
MdePkg 5.41% <ø> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 4.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 02 '24 19:07 codecov-commenter