mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

[202405][REBASE&FF]MdeModulePkg: VariableRuntimeDxe: Add host-based unit tests

Open Javagedes opened this issue 1 year ago • 1 comments

Description

Adds hostbased unit tests for VariableRuntimeDxe including converting some Self Certification Test (SCT)s into Host Based Unit Tests.

Includes: https://github.com/microsoft/mu_basecore/commit/c060edec1f44f2995ecd8dcfce4d5a47ec11f139 https://github.com/microsoft/mu_basecore/commit/d1ed38e06d4692123b42059185a5579bc72bfde5 https://github.com/microsoft/mu_basecore/commit/863063fd0e305e6b7b95a132f1d3e74c77ff4f98

  • [ ] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [x] Includes tests?
    • Creates multiple new tests for VariableRuntimeDxe
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

<Please describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

Javagedes avatar Jun 26 '24 16:06 Javagedes

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@fb60055). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...y/VarCheckPolicyLib/VarCheckPolicyLibVariableDxe.c 80.00% 2 Missing :warning:
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #967   +/-   ##
=================================================
  Coverage                  ?    0.60%           
=================================================
  Files                     ?      633           
  Lines                     ?   217575           
  Branches                  ?     1337           
=================================================
  Hits                      ?     1317           
  Misses                    ?   216213           
  Partials                  ?       45           
Flag Coverage Δ
MdeModulePkg 0.60% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 26 '24 17:06 codecov-commenter